Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments dav requests ignore file id #10934

Closed
skjnldsv opened this issue Aug 30, 2018 · 3 comments · Fixed by #12231
Closed

Comments dav requests ignore file id #10934

skjnldsv opened this issue Aug 30, 2018 · 3 comments · Fixed by #12231

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Aug 30, 2018

  1. open a file sidebar
  2. add a comment
  3. open another file sidebar
  4. see the comment from the previous file appear on this file as well
  5. see the network requests use the second file id and the first comment id still returning a proper response

@rullzer @MorrisJobke @danxuliu

@skjnldsv skjnldsv added bug 1. to develop Accepted and waiting to be taken care of feature: dav feature: comments labels Aug 30, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Aug 30, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8858 ((please ignore)), #4 (File requests / Files Drop for the community), #9969 (Enable sabre/dav's locking feature [feature request]), #5554 (Apps files from theme are being ignored), and #9955 (Request a valid property for DAV opendir).

@RuudschMaHinda
Copy link
Member

RuudschMaHinda commented Oct 24, 2018

The same bug appears with tags, group associations of apps, shared, versions (will try the meta app, to see if it is also affected - depending on what happens this might give further clues)
I have people that use the side panel for a reason, it is generally very good. This bug makes it basically unusable without reloading the entire page.

EDIT:
Could not check with metadata app, outdated requirements

The passwords app does not show this misbehabiour though.

@RuudschMaHinda
Copy link
Member

RuudschMaHinda commented Oct 25, 2018

I just observed something interesting:
The Problem with the group-checkmark in the app store is not affected in a completely new installation of NC 14.0.3
When selecting the details for different files it still has some issues, but not as bad as showing only the activities of previous selected files, but showing the current activities AND the previous activities.

That is on a completely fresh install of NC 14.0.3 - I don't have that luxury with the other install though. It might have something to do with an old database on the other server? (upgraded since owncloud 6)

rullzer added a commit that referenced this issue Nov 2, 2018
fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer added a commit that referenced this issue Nov 6, 2018
fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants