Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sending the password for a share by Nextcloud Talk #10238

Merged
merged 7 commits into from
Jul 24, 2018
Merged

Add support for sending the password for a share by Nextcloud Talk #10238

merged 7 commits into from
Jul 24, 2018

Commits on Jul 24, 2018

  1. Add "password_by_talk" column to "share" table in the database 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    49fd17f View commit details
    Browse the repository at this point in the history

  2. Add "sendPasswordByTalk" property to shares 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    88600f4 View commit details
    Browse the repository at this point in the history

  3. Store "sendPasswordByTalk" property of mail shares in the database 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    dd0c5e2 View commit details
    Browse the repository at this point in the history

  4. Honour "sendPasswordByTalk" property in mail shares 

    When a password was set for a mail share an e-mail was sent to the
recipient with the password. Now the e-mail is no longer sent if the
password is meant to be sent by Talk.

However, before the e-mail was not sent when the share was updated but
the password was not changed. Now an e-mail is sent in that case too if
switching from a password sent by Talk to a password sent by mail.

On the other hand, when switching from a password sent by mail to a
password sent by Talk it is mandatory to change the password; otherwise
the recipient would already have access to the share without having to
call the sharer to verify her identity.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    d582a66 View commit details
    Browse the repository at this point in the history

  5. Add support for sending the password by Talk to ShareAPIController 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    7849630 View commit details
    Browse the repository at this point in the history

  6. Add event to load additional scripts in the auth page for public shares 

    Before the public share authentication page is rendered now an event to
load additional scripts is dispatched. Thanks to this any app can load
its own scripts that, when run on the browser, adjust as needed the page
generated by the server.

Note, however, that during the handling of the event apps are only able
to add scripts or styles to be loaded; they can not render arbitrary
content on the page, or change how the content is rendered by the
original template; all those changes have to be done by the scripts at
run-time.

This implies that the scripts of the apps can use only those parameters,
like the token of the share, added to the page when it is generated by
the "publicshareauth" template. Due to this, and given that the event is
being introduced to be used by Talk to inject the UI needed to request
the password for a share, the token of the share is now provided in the
generated page, just like done in the public share page.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    96108ab View commit details
    Browse the repository at this point in the history

  7. Make possible to enable "sending password by Talk" from the share menu 

    Until now the password to be sent by mail was set by enabling a checkbox
in the share menu and then entering the password in an input field shown
below. Now, when Talk is enabled, another item is added to the share
menu to do the same for a password to be sent by Talk.

Sending the password by mail and sending it by Talk are mutually
exclusive actions, so when one of the checkboxes is enabled the other
one is automatically disabled.

Note that the icon set for the field, "icon-passwordtalk", does not
currently exist; it simply mimics the "icon-passwordmail" (which does
not exist either) used for the field of the password protect by mail to
get the right padding in the menu.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    9110935 View commit details
    Browse the repository at this point in the history