Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix avatar sizing for comments #10394

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Fix avatar sizing for comments #10394

merged 2 commits into from
Jul 25, 2018

Conversation

juliushaertl
Copy link
Member

  • Limit small avatar rendering only to inline mentions
  • Use small loading indicator for avatars smaller than 32px

The overlay in the loading preview is only caused by the browser when stopping the execution to make a screenshot. 😉
Before:
image
image

After:
image
image

Fixes #10381

@juliushaertl juliushaertl added design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Jul 25, 2018
@juliushaertl juliushaertl added this to the Nextcloud 14 milestone Jul 25, 2018
MorrisJobke
MorrisJobke approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke mentioned this pull request Jul 25, 2018
Merged
21 tasks
skjnldsv
skjnldsv approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it so much!! such tiny stuff yet so great addition! :D

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2018
@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 25, 2018 •
edited
Loading

CI at https://drone.nextcloud.com/nextcloud/server/9241

@MorrisJobke MorrisJobke merged commit cf98d9c into master Jul 25, 2018
@MorrisJobke MorrisJobke deleted the bugfix/10381/fix-avatar-sizing branch July 25, 2018 13:04
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@rullzer rullzer Awaiting requested review from rullzer

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@juliushaertl @MorrisJobke @skjnldsv