Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append cache bump parameter to scss files URL #10484

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Append cache bump parameter to scss files URL #10484

merged 1 commit into from
Aug 1, 2018

Conversation

juliushaertl
Copy link
Member

Steps to reproduce:

  1. Change the color value in the theming app
  2. Open any other page (without hard reload)

Before:
The old theming color was used

After:
The new theming color is used, even without hard refresh

@juliushaertl juliushaertl added this to the Nextcloud 14 milestone Aug 1, 2018
skjnldsv
skjnldsv approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@MorrisJobke MorrisJobke mentioned this pull request Aug 1, 2018
Closed
51 tasks
@rullzer rullzer merged commit b5c5fae into master Aug 1, 2018
@rullzer rullzer deleted the bugfix/noid/theming-cache-update branch August 1, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
bug feature: theming
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@juliushaertl @rullzer @skjnldsv