Clears the local storage after logout

[weeman1337]

The logout controller adds a param to the redirect url. Then the login code checks if it's there and clears the local storage. I also added a note this can be taken out again if the browsers support Clear-Site-Data properly.

closes #10859

[juliushaertl]

Clearing all local storage will cause the setting videoDisabled from the talk app to be removed. I think we should not clear all data if we cannot be sure that it is restored during the login again.

[georgehrke]

Clearing all local storage will cause the setting videoDisabled from the talk app to be removed. I think we should not clear all data if we cannot be sure that it is restored during the login again.

@juliushaertl We want to use local storage in Calendar and Contacts, to speed up loading when you open the page, but obviously, you don't want your events and contacts to remain in local storage once you logged out.

Maybe videoDisabled should use iConfig::getUserValue?

Nevermind. Of course settings should be persisted in the user config.

[ChristophWurst]

Side note: there's also session storage. For one, this can be used in apps for data that must not remain forever but we also might want to clear that on logout.

[weeman1337]

@ChristophWurst jep - I added cleanup of the SessionStorage.

[rullzer]

From a security point of view I'd want

• Clear this aways when reaching the login page javascript
• Have some logic to clear this when the logout button is pressed

Currently that would means to just always clear it when the login page is loaded. As this is where you are also redirected when your session expired etc.

Of course settings should be stored in the DB as well ;) to obtain them if the local storage is empty etc.

[MorrisJobke]

@weeman1337 I guess this is nothing that will be ready and merged until late Wednesday? Then we would need to move this to 16.

[MorrisJobke]

Let's move it to 16.

[ChristophWurst]

Hey @weeman1337 :) Could you rebase onto latest master? Than we can integrate this into Nextcloud 16 ✌️

[skjnldsv]

Hey @weeman1337 :) Could you rebase onto latest master? Than we can integrate this into Nextcloud 16

Done

[skjnldsv]

sh: 1: kill: No such process

Unrelated

[deusoz]

It seems to me that the clearing of local storage has broken the JSXC chat app which no longer autologs in chat user for NC16.
jsxc/jsxc#783