Add worker-src to CSP #11040
Merged
Add worker-src to CSP #11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
nickvergessen,
ChristophWurst,
blizzz,
juliushaertl and
skjnldsv
|
I have no idea how to review this :/ |
ChristophWurst
previously requested changes
Sep 4, 2018
| * @since 15.0.0 | ||
| */ | ||
| public function disallowWorkerSrcDomain(string $domain) { | ||
| $this->allowedWorkerSrcDomains[] = array_diff($this->allowedWorkerSrcDomains, [$domain]); |
There was a problem hiding this comment.
This doesn't seem right.
$ php -a
Interactive shell
php > $arr = [1, 2, 3];
php > print_r($arr);
Array
(
[0] => 1
[1] => 2
[2] => 3
)
php > $arr[] = array_diff($arr, [2]);
php > print_r($arr);
Array
(
[0] => 1
[1] => 2
[2] => 3
[3] => Array
(
[0] => 1
[2] => 3
)
)
php >
But
php > $arr = [1, 2, 3];
php > $arr = array_diff($arr, [2]);
php > print_r($arr);
Array
(
[0] => 1
[2] => 3
)
php >
does 😉
Fixes #11035 Since the child-src directive is deprecated (we should kill it at some point) we need to have the proper worker-src available Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
feature/11035/worker-src
branch
from
6ba3805
to
8354c50
Compare
|
@skjnldsv it is mostly following the code. The CSP is pretty straight forward. |
skjnldsv
approved these changes
Sep 4, 2018
ChristophWurst
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11035