Fix usage of deprecated OC.webroot #11691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add to #11045 It's also in:
|
This was referenced Oct 9, 2018
Done, except for that one. Where can I find the repo?
API not removed, so not adding this to the ticket. |
|
|
Mind sharing where that infinite recursion starts? |
|
|
I'm not gonna comment on my latest commit. |
MorrisJobke
reviewed
Oct 9, 2018
core/js/js.js
Outdated
| @@ -293,7 +293,7 @@ var OCP = {}, | |||
| * @since 8.2 | |||
| */ | |||
| getRootPath: function() { | |||
| return OC.getRootPath(); | |||
| return OC.webroot; | |||
MorrisJobke
added
4. to release
|
JSUnit fails ... |
MorrisJobke
added
2. developing
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/fix-usage-deprecated-oc-webroot
branch
from
b84b9fe
to
9af69ca
Compare
|
Fixed the tests, squashed and rebased. |
ChristophWurst
added
3. to review
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref
server/core/js/js.js
Lines 53 to 62 in d07c5db
This is a big one. I deem it's a bad idea to remove this now (even though from a deprecation time line it would be okay) because it's used so much. However, I search-and-replace'd all usages I could find locally.