fixes the check for postgresql #16461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
MorrisJobke
approved these changes
Jul 18, 2019
|
/backport to stable16 |
|
I'm, struggling with the backport. Yes I know that it could happen that your instance is not working before as well, but if you have any other or none locking mechanism enabled, the broken query is not used/executed. Maybe we could simply check the version in the query and do some old school insert-and-catch-errors instead. |
rullzer
approved these changes
Jul 26, 2019
|
backport to stable16 in #16553 |
|
Closed the back port. |
blizzz
added a commit
that referenced
this pull request
Jul 26, 2019
… in favor of the generic way fixes #15613 properly and overrides #16461 Signed-off-by: Arthur Schiwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that's the single check for the DB version, I did not find another one. But that's only active on setup, not on upgrade.
references: