Add accessibility label to show password checkbox

[nesb0t]

Fixes #15965.

Added aria-label to show password checkbox. Tested and verified with NVDA.

[jancborchardt]

Thank you @nesb0t for the contribution! :)

Based on the comments from @skjnldsv and @MarcoZehe, could I ask you to change the following:

• Instead of aria-label on the checkbox, the text can be put into the label for="show" block directly after.
• The label for="show" then also needs class="hidden-visually" just like the checkbox so it’s only visible for screenreaders.
• It should be translatable in the way @skjnldsv suggested.

Let us know if you need any help. ♥

[rullzer]

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

[kesselb]

Thank you @nesb0t for the contribution! :)

Based on the comments from @skjnldsv and @MarcoZehe, could I ask you to change the following:

* Instead of `aria-label` on the checkbox, the text can be put into the `label for="show"` block directly after.

* The `label for="show"` then also needs `class="hidden-visually"` just like the checkbox so it’s only visible for screenreaders.

* It should be translatable in the way @skjnldsv suggested.

Let us know if you need any help. ♥

@skjnldsv is this done? ;)

[skjnldsv]

God dammit

[kesselb]

Sorry 🙈

[skjnldsv]

Sorry

All good ;)
I missed the other comments! It's indeed the thing to do!

[kesselb]

The label for="show" then also needs class="hidden-visually" just like the checkbox so it’s only visible for screenreaders.

Don't forget ;)

[skjnldsv]

god dammit

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!