treat LDAP error 50 as auth issue, prevents lost server connection errors #17595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
blizzz
requested review from
rullzer,
ChristophWurst,
juliushaertl and
skjnldsv
|
/backport to stable17 |
|
/backport to stable16 |
skjnldsv
approved these changes
Oct 21, 2019
|
backport to stable17 in #17617 |
|
backport to stable16 in #17618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce if you have such an LDAP server on hand:
Excpected behaviour is that login failed, the login screen (and perhaps the option to reset the password).
Actual behaviour was that an Internal server error was presented.
This change was found working with a customer.