Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weird KDE bug with loginflowv2 #17626

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Fix weird KDE bug with loginflowv2 #17626

merged 1 commit into from
Oct 26, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 21, 2019

It seems that KDE by default opens the url in secret.
Should fix: nextcloud/desktop#1412

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer
Fix weird KDE bug with loginflowv2
0a2175a 
It seems that KDE by default opens the url in secret.
Should fix: nextcloud/desktop#1412

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Oct 21, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Oct 21, 2019
@rullzer
Copy link
Member Author

rullzer commented Oct 21, 2019

/backport to stable17

@rullzer
Copy link
Member Author

rullzer commented Oct 21, 2019

/backport to stable16

@rullzer rullzer mentioned this pull request Oct 21, 2019
Closed
@kesselb
Copy link
Contributor

kesselb commented Oct 21, 2019

How do you ensure that a token is not used twice? What do you think of adding setStarted to flowDone, set it to 2 and check for a value < 2 in startLoginFlow?

@rullzer
Copy link
Member Author

rullzer commented Oct 21, 2019

How do you ensure that a token is not used twice? What do you think of adding setStarted to flowDone, set it to 2 and check for a value < 2 in startLoginFlow?

We don't right now. The token gets cleared once the flow is completed.
So the only thing that can happen now is that you open the same flow twice.

@kesselb
Copy link
Contributor

kesselb commented Oct 22, 2019

Thanks @rullzer 👍 Missed $this->mapper->delete($data) ;)

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 23, 2019
@rullzer rullzer merged commit bc4ed80 into master Oct 26, 2019
@rullzer rullzer deleted the fix/weird_kde/loginflowv2 branch October 26, 2019 11:53
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 26, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #17688

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 26, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #17689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

[2.6.0] Your login token is invalid or has expired (webflow login)
3 participants
@rullzer @kesselb @ChristophWurst