Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] relax strict getHome behaviour for LDAP users in a shadow state #18882

Merged
merged 5 commits into from
Jan 15, 2020
Merged

[stable18] relax strict getHome behaviour for LDAP users in a shadow state #18882

merged 5 commits into from
Jan 15, 2020

Commits on Jan 14, 2020

  1. relax strict getHome behaviour for LDAP users in a shadow state 

    * simplifies deletion process
* less strange behaviour when looking up home storage (as long as it is local)
* thus could enable transfer ownerships after user went invisible on ldap

Signed-off-by: Arthur Schiwon <[email protected]>
    @blizzz
    blizzz authored and Backportbot committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    dcd5b15 View commit details
    Browse the repository at this point in the history

  2. decouple userExists from userExistsOnLDAP check 

    allows to mark users as offline right away, avoids a gap of being not a
user and causing weird side effects

Signed-off-by: Arthur Schiwon <[email protected]>
    @blizzz
    blizzz authored and Backportbot committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    b7a6a9d View commit details
    Browse the repository at this point in the history

  3. adjust tests 

    Signed-off-by: Arthur Schiwon <[email protected]>
    @blizzz
    blizzz authored and Backportbot committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    ad41056 View commit details
    Browse the repository at this point in the history

  4. remove superfluous tests 

    - user_ldap is not exposed to public api, it is always behind ldap_proxy
- this is too much for a unit test
- integration tests cover userExists implicitly

Signed-off-by: Arthur Schiwon <[email protected]>
    @blizzz
    blizzz authored and Backportbot committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    8cf4e61 View commit details
    Browse the repository at this point in the history

  5. ensure that only valid group members are returned 

    Signed-off-by: Arthur Schiwon <[email protected]>
    @blizzz
    blizzz authored and Backportbot committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    1aa91f6 View commit details
    Browse the repository at this point in the history