-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete avatar if a user is deleted #19929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
added
bug
3. to review
Waiting for reviews
feature: users and groups
labels
Mar 13, 2020
rullzer
approved these changes
Mar 13, 2020
kesselb
reviewed
Mar 13, 2020
juliushaertl
force-pushed
the
bugfix/user-delete-avatar
branch
from
March 13, 2020 13:46
231541d
to
0dba8a4
Compare
@juliushaertl mind to address the comments? |
nickvergessen
force-pushed
the
bugfix/user-delete-avatar
branch
from
March 24, 2020 20:13
0dba8a4
to
14a567a
Compare
nickvergessen
approved these changes
Mar 24, 2020
rullzer
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Mar 24, 2020
rullzer
reviewed
Mar 25, 2020
nickvergessen
force-pushed
the
bugfix/user-delete-avatar
branch
from
March 25, 2020 13:36
14a567a
to
7cc33b4
Compare
blizzz
approved these changes
Mar 25, 2020
Now you have failing tests though
|
Let me restart, since those run fine locally. |
juliushaertl
added
2. developing
Work in progress
and removed
4. to release
Ready to be released and/or waiting for tests to finish
labels
Mar 30, 2020
Signed-off-by: Julius Härtl <[email protected]>
juliushaertl
force-pushed
the
bugfix/user-delete-avatar
branch
from
April 24, 2020 14:27
7cc33b4
to
d74e904
Compare
Let's see if that works. |
georgehrke
approved these changes
Apr 24, 2020
juliushaertl
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
2. developing
Work in progress
labels
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure avatars are properly cleaned up if a user is deleted