Cleanup OC_Group usage a bit #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @schiessle and @PVince81 to be potential reviewers. |
|
Fine by me, when tests pass 👍 |
Not really: |
MorrisJobke
added
2. developing
rullzer
force-pushed
the
cleanup_oc_group_a_tad
branch
from
ab653b6
to
211ede2
Compare
This is deprecated internal stuff. Should not be used anymore. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
cleanup_oc_group_a_tad
branch
from
211ede2
to
04ece69
Compare
rullzer
added
3. to review
|
Fixed. |
Current coverage is 57.80% (diff: 100%)@@ master #2014 diff @@
==========================================
Files 1094 1094
Lines 62793 62936 +143
Methods 6994 7043 +49
Messages 0 0
Branches 0 0
==========================================
+ Hits 36289 36381 +92
- Misses 26504 26555 +51
Partials 0 0
|
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is deprecated internal stuff. Should not be used anymore.
Signed-off-by: Roeland Jago Douma [email protected]
CC: @MorrisJobke @nickvergessen @LukasReschke @ChristophWurst