-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use autowiring where possible in server container #22202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
icewind1991,
ChristophWurst,
kesselb and
blizzz
August 11, 2020 21:27
MorrisJobke
force-pushed
the
enh/noid/cleanup-servercontainer
branch
from
August 11, 2020 21:37
16ccc65
to
e1b7dd0
Compare
@ChristophWurst Thanks - resolved all of your comments. |
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
rullzer
force-pushed
the
enh/noid/cleanup-servercontainer
branch
from
August 13, 2020 03:43
920027d
to
8946402
Compare
rullzer
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but didn't test.
icewind1991
approved these changes
Aug 13, 2020
ChristophWurst
approved these changes
Aug 13, 2020
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Aug 13, 2020
Signed-off-by: Morris Jobke <[email protected]>
I just added |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31735: failuremysql8.0-php7.2Show full log
acceptance-app-files
Show full log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically removes the implicit wiring of dependencies where the automatic DI would also just work. The only real addition is the
serverRoot
alias that maps toOC::$SERVERROOT
.