Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide error if a background request fails during navigation #22458

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

ChristophWurst
Copy link
Member

If you open the dashboard but quickly navigate somewhere else, a toast
will show telling you that the weather status could not be fetched. As a
user I don't care about this. This is only relevant if the user intents
to no leave the page.

So let's not show a toast for aborted connections. This makes the UX a
tad smoother.

If you open the dashboard but quickly navigate somewhere else, a toast
will show telling you that the weather status could not be fetched. As a
user I don't care about this. This is only relevant if the user intents
to no leave the page.

So let's not show a toast for aborted connections. This makes the UX a
tad smoother.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: dashboard labels Aug 27, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Aug 27, 2020
@ChristophWurst ChristophWurst self-assigned this Aug 27, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 27, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32387: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
      │ Details view in Files app visibility could not be got
      │ Exception message: Element is no longer attached to the DOM
      │ For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      │ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      │ System info: host: 'b3afab534e61', ip: '172.27.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
      │ Driver info: driver.version: unknown
      │ Trying again
      │ 
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2020
@rullzer rullzer merged commit 2c6c5fe into master Aug 27, 2020
@rullzer rullzer deleted the fix/weather-status-navigate-error branch August 27, 2020 12:59
@rullzer rullzer mentioned this pull request Aug 28, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dashboard papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants