Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimp Oauth2 table #22502

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Pimp Oauth2 table #22502

merged 1 commit into from
Aug 31, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Aug 30, 2020

Fixes #12302

Before:
nov-06-2018 09-20-11

After:
after

@rullzer rullzer added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Aug 30, 2020
@rullzer rullzer added this to the Nextcloud 20 milestone Aug 30, 2020
Fixes #12302

Signed-off-by: Roeland Jago Douma <[email protected]>
@juliushaertl
Copy link
Member

Rebased and added some very minor additional styling fixes:

  • Move padding to the table cells so that the text is properly aligned with the labels
  • limit width so the delete button is more next to the actual data

image

</th>
<th id="headerSecret" scope="col">
{{ t('oauth2', 'Secret') }}
<th id="headerContent">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the id is not used, so we can drop that

@faily-bot
Copy link

faily-bot bot commented Aug 31, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32450: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #231 ('folder', 29, 11)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

@rullzer rullzer mentioned this pull request Aug 31, 2020
21 tasks
@rullzer rullzer merged commit 8c9f3a5 into master Aug 31, 2020
@rullzer rullzer deleted the fix/12302/oauth2_table branch August 31, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth 2.0 Client list breaks when secret is shown
3 participants