-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change free space calculation #22528
Conversation
Signed-off-by: Daniel Kesselberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Are the trashbin tests failing on master too? |
Signed-off-by: Daniel Kesselberg <[email protected]>
3552878
to
ac8051e
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32529: failuremysql8.0-php7.2Show full log
|
if ($key === 'filesystem_check_changes') { | ||
return \OC\Files\Cache\Watcher::CHECK_ONCE; | ||
} else { | ||
return $config->getSystemValue($key, $default); | ||
} | ||
}); | ||
$mockConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mockageddon 🙈
/backport to stable19 |
/backport to stable18 |
/backport to stable17 |
The backport to stable17 failed. Please do this backport manually. |
Close #22475
If neither
$userTrashbinSize
nor$systemTrashbinSize
are defined we have:$configuredTrashbinSize = (-1 < 0) ? -1 : -1;
,(bool)-1
is true and the freespace is always-1 - $trashbinSize
.That should work but no idea how it should be ;)