Re-fix transaction isolation level #22563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that this is somehow causing issues in various setups Ref server#22482 Ref spreed#4093 Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
requested review from
rullzer,
icewind1991,
ChristophWurst,
kesselb and
simonspa
icewind1991
approved these changes
Sep 3, 2020
|
@nickvergessen i've reverted those changes, and still having both problems of #22482 and nextcloud/spreed#4093
For #22482, uploaded 30 files > select them all > delete == Deadlocks on 4 out of 30 deletes. Full log hereFor nextcloud/spreed#4093 same behavior as described in the ticket (browser errors, Room not found messages, etc.)
|
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32590: failuremariadb10.4-php7.3Show full logmysql5.6-php7.2Show full log |
|
Should i try this fix ? or is this not working ? |
|
Please try and report if it works on your setup |
|
working on it now. let you know |
|
Interestingly for me it works (as discussed in the Talk room). I haven't applied the full patch but just add the one line back: |
|
Another "not work" feedback here :#22482 (comment) |
|
@nickvergessen I also revert back the changes |
|
I did some more tests and it seems to work for some cases. I only get one of the three different stack traces I had seen before, and after a second sync everything is fine - which was not the case before. But it definitely does not solve the issue completely unfortunately. |
|
@nickvergessen Looks like this issue happens when you select multiple files and delete them but if you delete files one by one there's no issue from what i can see. |
That's true. |
This comment has been minimized.
This comment has been minimized.
|
@nickvergessen any updates on this? |
|
Can you please put the following code as <?php
use Doctrine\DBAL\TransactionIsolationLevel;
require_once __DIR__ . '/lib/versioncheck.php';
require_once __DIR__ . '/lib/base.php';
$db = \OC::$server->getDatabaseConnection();
$c = \OC::$server->getConfig();
var_dump($db->inTransaction());
try {
if ($db->getDatabasePlatform() instanceof \Doctrine\DBAL\Platforms\MySQL80Platform) {
var_dump($db->executeQuery('SELECT @@GLOBAL.transaction_isolation, @@transaction_isolation')->fetchAll());
var_dump($db->setTransactionIsolation(TransactionIsolationLevel::REPEATABLE_READ));
var_dump($db->executeQuery('SELECT @@GLOBAL.transaction_isolation, @@transaction_isolation')->fetchAll());
var_dump($db->setTransactionIsolation(TransactionIsolationLevel::READ_COMMITTED));
var_dump($db->executeQuery('SELECT @@GLOBAL.transaction_isolation, @@transaction_isolation')->fetchAll());
} else {
var_dump($db->executeQuery('SELECT @@GLOBAL.tx_isolation, @@tx_isolation')->fetchAll());
var_dump($db->setTransactionIsolation(TransactionIsolationLevel::REPEATABLE_READ));
var_dump($db->executeQuery('SELECT @@GLOBAL.tx_isolation, @@tx_isolation')->fetchAll());
var_dump($db->setTransactionIsolation(TransactionIsolationLevel::READ_COMMITTED));
var_dump($db->executeQuery('SELECT @@GLOBAL.tx_isolation, @@tx_isolation')->fetchAll());
}
var_dump($db->executeQuery("SHOW GRANTS FOR '" . $c->getSystemValueString('dbuser') . "'@'" . $c->getSystemValueString('dbhost') . "'")->fetchAll());
var_dump($db->executeQuery("SHOW CREATE USER '" . $c->getSystemValueString('dbuser') . "'@'" . $c->getSystemValueString('dbhost') . "'")->fetchAll());
} catch (\Throwable $e) {
var_dump($e);
} |
|
Here you go: |
|
@nickvergessen Here you go: |
|
Is anyone willing to give me access to a failing server? No one of our engineering team can reproduce this locally or on their server, so it's really hard to debug. Use the SSH key from my github profile: https://github.com/nickvergessen.keys |
|
@nickvergessen me to send you a meeting invite ? And you can remote in ? |
Just sent you an email. When you're ready to join im on the meeting. |
|
Thanks for the help @axheli see email :) |
@nickvergessen: Kannst per Remote Desktop in mein Server schauen. |
|
Since this isn't solving it it seems I'm moving this to 21. |
So what do we do with all these sync errors and not able to delete files. At this point the system is not stable. |
|
MariaDB config, concated |
|
Hi everyone any updates on this? |
|
Should be fixed via #23109 now |
nickvergessen
deleted the
bugfix/22482/fix-setting-transaction-isolation-level
branch
|
@nickvergessen should this ticket be reopened since its not fixed? or are we referencing #23109 going forwarded |
|
This is a Pull request, not an issue and as per your comment it doesn't fix it, so it doesn't need to be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #18227
It seems that this is somehow causing issues in various setups
Fix #22482
Fix nextcloud/spreed#4093