Increase html body height to full content height

[raimund-schluessler]

This PR increases the html body height to match the full content height. Fixes #22606 and nextcloud-libraries/nextcloud-vue#1384.

This change is necessary, so that the popover boundaries are calculated correctly. Otherwise the every popover scrolls out of the viewport because body is to small.

Before:

After:

Although code-wise this is a small change, I am a bit afraid of breaking anything, since this affects more or less the root element of the website. I did some testing and didn't find anything which is broken by this change. However, this really needs a good test.

The fluttering of the status popover is due to the container being the body element. This can be fixed by choosing e.g. the header once nextcloud-libraries/nextcloud-vue#1389 is merged. I will do so in a follow up PR.

Also see nextcloud-libraries/nextcloud-vue#1384 for details.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32689: failure

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopy with data set #7 ('/single ' quote.txt', '/tar'get.txt')
Expected /tar'get.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:235

[nickvergessen]

This is a breaking change, right? Too close to a release for me in that case

[raimund-schluessler]

This is a breaking change, right? Too close to a release for me in that case

I don't know if it is breaking. But since master is already broken (you can't open any popover while scrolled down, including the status selection), I think a solution is necessary.

I am happy to see any other proposal.

[skjnldsv]

Couldn't find any bad outcome so far! 🤷

[nickvergessen]

Breaks the dashboard:

[nickvergessen]

As said above, I vote to not merge this and have a look after 20 is out.

[nickvergessen]

Also breaks Talk and mostlikely some other apps that add a scroller themselves:

1. Chat input is missing
2. Double scrolbar is added.