-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installing on Oracle #22643
Merged
Merged
Fix installing on Oracle #22643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty strings are stored as null in Oracle, so a column with NotNull can not have an empty string as default Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
3. to review
Waiting for reviews
feature: install and update
labels
Sep 7, 2020
/backport to stable19 |
/backport to stable18 |
nickvergessen
requested review from
rullzer,
MorrisJobke,
blizzz and
ChristophWurst
September 7, 2020 09:59
I will write a method into the oracle checker to error on this. |
ChristophWurst
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
Signed-off-by: Joas Schilling <[email protected]>
Pushed an addition to the checker. |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32748: failuremariadb10.4-php7.3Show full log
mysql8.0-php7.2Show full log
|
MorrisJobke
approved these changes
Sep 7, 2020
This was referenced Sep 7, 2020
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty strings are stored as null in Oracle,
so a column with NotNull can not have an empty string as default
Signed-off-by: Joas Schilling [email protected]