Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to run mysql5 tests anymore #24993

Merged
merged 1 commit into from
Jan 7, 2021
Merged

No need to run mysql5 tests anymore #24993

merged 1 commit into from
Jan 7, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 6, 2021

Signed-off-by: Roeland Jago Douma [email protected]

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added the 3. to review Waiting for reviews label Jan 6, 2021
@rullzer rullzer added this to the Nextcloud 21 milestone Jan 6, 2021
@faily-bot
Copy link

faily-bot bot commented Jan 6, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1037: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@rullzer rullzer merged commit ae2ca5b into master Jan 7, 2021
@rullzer rullzer deleted the ci/db_drop_mysql_5 branch January 7, 2021 07:44
@rullzer rullzer mentioned this pull request Jan 7, 2021
5 tasks
@nickvergessen
Copy link
Member

it's only for 21+ because no longer supported by dbal 3.0, right?

If so, installing should fail? and we need a warning like with the php version to prevent upgrades from breaking?

@MorrisJobke
Copy link
Member

If so, installing should fail? and we need a warning like with the php version to prevent upgrades from breaking?

Yep - makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants