dont return private storage interface from public mount interface #25392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
approved these changes
Jan 31, 2021
|
Psalm is a bit unhappy. server/lib/public/Files/Storage/IStorage.php Line 439 in d1bdd1c server/lib/private/Files/Storage/Common.php Line 334 in d1bdd1c |
|
and now psalm just crashes... |
icewind1991
added
2. developing
|
😞 It seems that a dev version is used for the security checks. I would ignore them for now and just care about
|
icewind1991
added
3. to review
|
Master is Nextcloud 22 now. |
rullzer
force-pushed
the
imountpoint-ocp-storage
branch
from
9fde931
to
a70f4a5
Compare
|
@icewind1991 please rebase for psalm and/or fix psalm issues |
rullzer
force-pushed
the
imountpoint-ocp-storage
branch
from
a70f4a5
to
200e11a
Compare
|
Seems psalm is right. Also with respect to the failed cache that doesn't fit the hierarchy... |
icewind1991
force-pushed
the
imountpoint-ocp-storage
branch
from
200e11a
to
7e44668
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
imountpoint-ocp-storage
branch
from
7e44668
to
7995c6e
Compare
|
psalm is happy |
|
Ah but conflicts now :( |
|
@icewind1991 conflicts |
skjnldsv
added
2. developing
Merged
skjnldsv
added
4. to release
skjnldsv
approved these changes
Oct 22, 2021
juliushaertl
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman [email protected]