Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper PHPDoc tags to files ApiController #26410

Merged
merged 2 commits into from
May 27, 2021
Merged

Conversation

MorrisJobke
Copy link
Member

Should make Psalm a bit more happy (because it does not need to infer it)

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Apr 1, 2021
@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone Apr 1, 2021
@rullzer
Copy link
Member

rullzer commented Apr 8, 2021

Psalm is not happy

@J0WI
Copy link
Contributor

J0WI commented Apr 20, 2021

getUser() may return null:

* @return IUser|null Current user, otherwise null
*/
public function getUser() {

@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
MorrisJobke and others added 2 commits May 21, 2021 16:58
@MorrisJobke
Copy link
Member Author

Rebased - maybe Psalm is happy.

@MorrisJobke
Copy link
Member Author

CI failure is unrelated

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke merged commit e312905 into master May 27, 2021
@MorrisJobke MorrisJobke deleted the fix/noid/phpdoc branch May 27, 2021 19:00
@LukasReschke
Copy link
Member

This broke tests on master :(

LukasReschke added a commit that referenced this pull request May 28, 2021
Regression by #26410

Signed-off-by: Lukas Reschke <[email protected]>
LukasReschke added a commit that referenced this pull request May 28, 2021
Regression by #26410

Signed-off-by: Lukas Reschke <[email protected]>
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants