Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DB code in the CalDAV backend #26719

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Clean up DB code in the CalDAV backend #26719

merged 3 commits into from
Apr 23, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Apr 23, 2021 •
edited
Loading

  • Drop default parameter override with default
  • Use executeQuery and executeUpdate as replacement of the deprecated execute
  • Close open cursors

Those three steps are split into separate commits. You may review individually.

Found while working on #26083.

@ChristophWurst ChristophWurst added this to the Nextcloud 22 milestone Apr 23, 2021
@ChristophWurst ChristophWurst self-assigned this Apr 23, 2021
rullzer
rullzer approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

nickvergessen
nickvergessen previously requested changes Apr 23, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinite loop in CalDavBackend

@ChristophWurst
Close open cursors
323f956 
Signed-off-by: Christoph Wurst <[email protected]>
tcitworld
tcitworld approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@nickvergessen nickvergessen merged commit 04c15e7 into master Apr 23, 2021
@nickvergessen nickvergessen deleted the chore/dav-cleanup-query-usage branch April 23, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@tcitworld tcitworld tcitworld approved these changes

@brantje brantje Awaiting requested review from brantje

@kesselb kesselb Awaiting requested review from kesselb

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@artemanufrij artemanufrij Awaiting requested review from artemanufrij

@aleister09 aleister09 Awaiting requested review from aleister09

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @nickvergessen @tcitworld