Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP7.3 #29286

Merged
merged 6 commits into from
Feb 1, 2022
Merged

Drop PHP7.3 #29286

merged 6 commits into from
Feb 1, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 18, 2021

Fixes #29258

Todo

To be merged once 23 is branched off.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Oct 18, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 24 milestone Oct 18, 2021
@ChristophWurst ChristophWurst requested a review from a team October 18, 2021 07:22
@ChristophWurst ChristophWurst self-assigned this Oct 18, 2021
@ChristophWurst ChristophWurst requested review from nickvergessen and PVince81 and removed request for a team October 18, 2021 07:22
@come-nc
Copy link
Contributor

come-nc commented Nov 16, 2021

It seems a lot of images in .drone.yml use PHP 7.3.

It also needs to be removed from .github/workflows/oci.yml

@nickvergessen
Copy link
Member

It also needs to be removed from .github/workflows/oci.yml

I can use my script to drop this from all the app repositories.

@come-nc
Copy link
Contributor

come-nc commented Nov 30, 2021

It would be good to finish and merge this before 8.1 is added to CI to avoid queuing too much jobs.

@skjnldsv
Copy link
Member

@ChristophWurst ready when you are 😉

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Nov 30, 2021
@skjnldsv skjnldsv marked this pull request as ready for review November 30, 2021 12:10
@skjnldsv skjnldsv requested a review from a team November 30, 2021 12:10
@ChristophWurst
Copy link
Member Author

CI needs adjustment. Feel free to take over.

@come-nc
Copy link
Contributor

come-nc commented Dec 6, 2021

The following images still need 7.4 equivalents:

image: ghcr.io/nextcloud/continuous-integration-acceptance-php7.3:acceptance-php7.3-3
      image: ghcr.io/nextcloud/continuous-integration-integration-php7.3:latest
  image: ghcr.io/nextcloud/continuous-integration-integration-php7.3:latest
  image: nextcloudci/litmus-php7.3:litmus-php7.3-1
  image: nextcloudci/php7.3-memcached:php7.3-memcached-3
  image: nextcloudci/samba-native-php7.3:samba-native-php7.3-1
  image: nextcloudci/samba-non-native-php7.3:samba-non-native-php7.3-1
  image: nextcloudci/webdav-apache-php7.3:webdav-apache-php7.3-3

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2021

The following images still need 7.4 equivalents:

image: ghcr.io/nextcloud/continuous-integration-acceptance-php7.3:acceptance-php7.3-3
      image: ghcr.io/nextcloud/continuous-integration-integration-php7.3:latest
  image: ghcr.io/nextcloud/continuous-integration-integration-php7.3:latest
  image: nextcloudci/litmus-php7.3:litmus-php7.3-1
  image: nextcloudci/php7.3-memcached:php7.3-memcached-3
  image: nextcloudci/samba-native-php7.3:samba-native-php7.3-1
  image: nextcloudci/samba-non-native-php7.3:samba-non-native-php7.3-1
  image: nextcloudci/webdav-apache-php7.3:webdav-apache-php7.3-3

You can trigger them in https://github.com/nextcloud/docker-ci/actions/workflows/docker.yml

@come-nc
Copy link
Contributor

come-nc commented Dec 6, 2021

You can trigger them in https://github.com/nextcloud/docker-ci/actions/workflows/docker.yml

I actually cannot: "Error: The user required level is not sufficient"

MichaIng added a commit to MichaIng/DietPi that referenced this pull request Dec 6, 2021
+ DietPi-Software | Nextcloud: Assure that Nextcloud v23 is installed on Stretch and Buster, since v24 will drop support for PHP7.3: nextcloud/server#29286
@nickvergessen
Copy link
Member

I actually cannot: "Error: The user required level is not sufficient"

@come-nc you have been promoted :)

ChristophWurst and others added 6 commits January 25, 2022 17:25
@come-nc
Copy link
Contributor

come-nc commented Jan 27, 2022

@nickvergessen All tests are finally passing, except samba which is broken as well on master.

So what are the next steps to get this merged?

@nickvergessen
Copy link
Member

I will bump all apps friday, after that is in we can merge this here

@nickvergessen
Copy link
Member

#30896 Review time

@come-nc
Copy link
Contributor

come-nc commented Jan 31, 2022

Good to merge then?
The only drone failure is the samba one and is not related.

@come-nc come-nc merged commit d635d58 into master Feb 1, 2022
@come-nc come-nc deleted the enhancement/drop-php-7-3 branch February 1, 2022 09:50
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2022
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of php7.3
5 participants