fix populating account array with missing default values #29397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
bug
3. to review
blizzz
requested review from
skjnldsv,
Pytal,
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
blizzz
added
2. developing
blizzz
force-pushed
the
fix/noid/profile-missing-def-values
branch
from
3aa67e4
to
405478e
Compare
blizzz
commented
Oct 22, 2021
Comment on lines
-519
to
-520
| [], | ||
| [], |
There was a problem hiding this comment.
@Pytal unless there is a valid case where we receive empty values?
There was a problem hiding this comment.
Nope, previous change was just a quick fix. This updated implementation makes much more sense :)
blizzz
added
3. to review
- both $userData and $defaultUserData have numeric indices - each element contains at least the name and other fields - appending the missing data array is sufficient Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/profile-missing-def-values
branch
from
405478e
to
e26d6f0
Compare
Pytal
approved these changes
Oct 23, 2021
skjnldsv
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I was greeted with the blue page of death and "OCP\Accounts\PropertyDoesNotExistException Property organisation does not exist.". Turns out the population of missing default values was having a glitch.