Minor optimizations for saving user personal information #30863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
nickvergessen
requested changes
Jan 26, 2022
nickvergessen
added
2. developing
|
|
tcitworld
reviewed
Jan 27, 2022
CarlSchwan
force-pushed
the
performance/saving-user-profile-info
branch
2 times, most recently
from
acc00f6
to
f01b033
Compare
|
Found some cases there the event wasn't fired twice, so I added some more handling |
CarlSchwan
force-pushed
the
performance/saving-user-profile-info
branch
2 times, most recently
from
da5d57e
to
810efb3
Compare
nickvergessen
approved these changes
Feb 17, 2022
CarlSchwan
commented
Feb 24, 2022
come-nc
approved these changes
Feb 24, 2022
CarlSchwan
force-pushed
the
performance/saving-user-profile-info
branch
from
810efb3
to
869a5ba
Compare
CarlSchwan
force-pushed
the
performance/saving-user-profile-info
branch
from
869a5ba
to
830122d
Compare
|
Drone tests are all broken => retriggering them just in case |
Merged
Merged
* Remove double hook: the OC_User::changeUser triggers an OC\AccountManager::userUpdated and the app is already listening to this signal in its Application definition * Make createCard not check if an card exists if we already checked previously. We also don't try to get the card if the user is disabled as we don't use the card in this case We this change we go from 100 DB requests to 80 DB requests when saving an user email address. Signed-off-by: Carl Schwan <[email protected]> (cherry picked from commit c6fd482)
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
performance/saving-user-profile-info
branch
from
830122d
to
e71db40
Compare
|
Seems to be still broken |
|
ci failures unrelared (due to the toast.scss change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition
Make createCard not check if a card exists if we already checked
previously. We also don't try to get the card if the user is disabled
as we don't use the card in this case
Batch insert card properties: instead of doing 6-8 inserts at a time, do all of
them at the same time (using a transaction)
We this change we go from 102 DB requests to ~81 DB requests when saving
a user email address. Still way too much in my opinion but it's a start :)
Future improvements:
you trigger various hooks to regenerate the addressbook card and the birthday
calendar, and create an audit log entry, activity entry, ...