Connectivity check: test https OR ELSE http

[julien-nc]

Instead of https AND http.

As tested domains can be set by admins with connectivity_check_domains config value, we can't know for sure those domains are reachable with both http and https.

This avoids the connectivity warning in admin setting's overview section when a domain is only accessible via either http or https.

[come-nc]

That means that an SSL expiration problem for instance would not be spotted if the http version works?

I understand that more and more domains are not available by http, but I feel like https should always work?

[julien-nc]

@come-nc I agree. How about only testing https? It feels a bit harsh...

Another (heavy) solution would be to have a config setting to choose which protocol is tested in this connectivity check.

[come-nc]

I did not understand the context at first, but this is only used to test whether the server has internet access.
So testing https only seems reasonnable to me.

Other solution would be to allow putting URIs with protocol instead of just domains in the config, but I would say that is overkill for this feature.

[julien-nc]

😁 The context is someone who does not have proper internet access but who needs this test to pass to use a custom appstore URL. So they provide custom connectivity_check_domains and some of them are accessible via http only, some others are accessible via https only.

[julien-nc]

@come-nc Rebased on master, added method signature types.

It would be awesome to backport this to stable23 and stable22.

[come-nc]

My fear is that http is a lot less useful check, you may be on a network where all external accesses are redirected to a blocker page. With https this would be detected.

[julien-nc]

@come-nc How about this instead? 3b6e463
If no protocol is set, then we keep the same behaviour (test both http and https), if a protocol is set, just try this one.
If you agree I'll push it in this PR's branch.

[come-nc]

@come-nc How about this instead? 3b6e463 If no protocol is set, then we keep the same behaviour (test both http and https), if a protocol is set, just try this one. If you agree I'll push it in this PR's branch.

👍 The regex is missing a ^ at the start, otherwise it’s good for me.

[julien-nc]

@come-nc Great, nice catch, thanks for the feedback.
Rebased on master.

[julien-nc]

Drone failure seems unrelated.

[julien-nc]

/backport to stable23

[julien-nc]

/backport to stable22