Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit missing primary key fail to new tables and comment out for now #31580

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Limit missing primary key fail to new tables and comment out for now #31580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32ede54
Limit missing primary key fail to new tables
nickvergessen Mar 15, 2022
3bed983
Disable for now again until more apps are fixed
nickvergessen Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/private/DB/MigrationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,8 +634,8 @@ public function ensureOracleConstraints(Schema $sourceSchema, Schema $targetSche
if ($isUsingDefaultName && \strlen($table->getName()) - $prefixLength >= 23) {
throw new \InvalidArgumentException('Primary index name on "' . $table->getName() . '" is too long.');
}
} elseif (!$primaryKey instanceof Index) {
throw new \InvalidArgumentException('Table "' . $table->getName() . '" has no primary key and therefor will not behave sane in clustered setups.');
// } elseif (!$primaryKey instanceof Index && !$sourceTable instanceof Table) {
// throw new \InvalidArgumentException('Table "' . $table->getName() . '" has no primary key and therefor will not behave sane in clustered setups.');
PVince81 marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down