Migrate from ILogger to LoggerInterface in lib/private #31609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to do the same for the tests, otherwise they fails |
come-nc
requested review from
a team,
nickvergessen,
blizzz and
juliushaertl
and removed request for
a team
come-nc
added
3. to review
|
CI is happy appart from S3 jobs which fail a lot. |
tcitworld
reviewed
Mar 22, 2022
tcitworld
approved these changes
Mar 22, 2022
CarlSchwan
approved these changes
Mar 22, 2022
come-nc
force-pushed
the
fix/migrate-away-from-ilogger
branch
3 times, most recently
from
d140203
to
c89dcb8
Compare
|
/rebase |
Merged
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Encryption constructor is problematic and should still be fixed later. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/migrate-away-from-ilogger
branch
from
c89dcb8
to
6d35459
Compare
Merged
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet [email protected]