Fixed it so that when performing the search, it correctly fills the u… #32308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
reviewed
May 9, 2022
| } | ||
|
|
||
| if (isset($contact['FN'])) { | ||
| $entry->setFullName($contact['FN']); | ||
| } | ||
|
|
||
| $avatarPrefix = "VALUE=uri:"; |
There was a problem hiding this comment.
I wonder if the two way should be keep. e.g. first try looking if the PHOTO property exists and if not fallback to the UID?
There was a problem hiding this comment.
@mstolf I left line 323 throw 327 in place and only added 314 throw 318 and its working for me
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
|
Fixed already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging the code, it was possible to identify that the $contacts array did not have the value 'PHOTO' in this way, not setting the avatar and not loading in the contacts search
I'm not sure if the way I made the correction is the best possible, so if it's incorrect this way you can let me know and direct me what would be the best way to make the correction
Fix #32271