Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Allow to tweak default scopes for accounts #32448

Closed
wants to merge 1 commit into from

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #31623

@szaimen
Copy link
Contributor

szaimen commented May 17, 2022

I suppose if we merge this we would need a new minor release?
cc @PVince81

@blizzz blizzz added the 3. to review Waiting for reviews label May 19, 2022
@blizzz blizzz mentioned this pull request Jun 9, 2022
2 tasks
@blizzz
Copy link
Member

blizzz commented Jun 13, 2022

moving to 24.0.3

@blizzz blizzz mentioned this pull request Jun 17, 2022
@szaimen
Copy link
Contributor

szaimen commented Jun 25, 2022

So seems like we will not merge this? then lets close it.
cc @PVince81 @AndyScherzinger

@AndyScherzinger
Copy link
Member

I am fine to merge it, like @blizzz assigned it, let's just see that we get it merged before the next maintenance release, same for the 23 backport.

@szaimen
Copy link
Contributor

szaimen commented Jun 25, 2022

Okay, lets @PVince81 merge it as we probably need to publish a 23.1.0 then...

/**
* The list of allowed scopes
*
* @since 25.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs adjustment

@@ -1,9 +1,11 @@
<?php

/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o.O

/**
* The list of allowed properties
*
* @since 25.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs adjustment

@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
18 tasks
@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 7, 2022
@skjnldsv skjnldsv mentioned this pull request Jul 8, 2022
12 tasks
@blizzz blizzz mentioned this pull request Jul 18, 2022
@blizzz
Copy link
Member

blizzz commented Jul 18, 2022

moving to 24.0.4…

@tcitworld or @szaimen do you mind taking care of the requested adjustments?

@blizzz blizzz mentioned this pull request Aug 1, 2022
@blizzz
Copy link
Member

blizzz commented Aug 1, 2022

🏓

@blizzz
Copy link
Member

blizzz commented Aug 4, 2022

moving to 24.0.5.

@blizzz blizzz mentioned this pull request Aug 30, 2022
@blizzz
Copy link
Member

blizzz commented Sep 1, 2022

moving to 24.0.6

@AndyScherzinger @PVince81 if nobody is taking ownership of this PR I'd just close it next time 👀

@tcitworld tcitworld closed this Sep 1, 2022
@tcitworld
Copy link
Member

It's more like a feature, no need to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement feature: users and groups php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants