Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] load dashboard widgets of enabled apps only #33156

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #32997

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.7 milestone Jul 7, 2022
@skjnldsv skjnldsv mentioned this pull request Jul 7, 2022
13 tasks
@blizzz blizzz changed the title [stable23] [stable24] load dashboard widgets of enabled apps only [stable23] load dashboard widgets of enabled apps only Jul 7, 2022
@blizzz blizzz added the 2. developing Work in progress label Jul 7, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested review from Pytal and come-nc July 27, 2022 15:05
@PVince81
Copy link
Member

/rebase

- per design, all enabled apps have their registration run
- limitations, e.g. enabled by group, are not considered in that state,
  because we do not have a session (and might need apps?)
- before instantiation of widget it has to be checked whether the providing
  app is actually enabled for the logged in user.
- a public interface is being changed, but it is not meant to be
  implemented or used outside of the core handling. Therefore save to
  backport.

Signed-off-by: Arthur Schiwon <[email protected]>
- might break install

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz mentioned this pull request Aug 1, 2022
Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz merged commit 105bdbe into stable23 Aug 1, 2022
@blizzz blizzz deleted the backport/32997/stable23 branch August 1, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants