Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement to diagnostics - log user name in setupForUserWith #33426

Closed

Conversation

starypatyk
Copy link
Contributor

While investigating slow loading of chat messages in Talk/Android I have been struggling with understanding why setup_fs is called many times during a single request.

It turned out that the setupForUserWith method is called for all participants of the chat who shared images in the chat.

The proposed change makes this analysis a bit easier.

Signed-off-by: Dariusz Olszewski <[email protected]>
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@sorbaugh
Copy link
Contributor

Hi @starypatyk, looks like your PR got caught in a cleanup! I'm reopening this for you and will look into getting your change in. Cheers!

@sorbaugh sorbaugh reopened this Aug 16, 2024
@sorbaugh
Copy link
Contributor

sorbaugh commented Aug 16, 2024

Hello again @starypatyk, while trying to resolve the conflict, we found out that we actually took another approach where the event got renamed/changed. So unfortunately we can't use your approach after all, hope that's alright!

@sorbaugh sorbaugh closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress feature: logging stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants