Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added --enabled and --disabled options to occ app:list #33546

Merged
merged 5 commits into from
Mar 19, 2024
Merged

added --enabled and --disabled options to occ app:list #33546

merged 5 commits into from
Mar 19, 2024

Conversation

adam-blakey
Copy link
Contributor

This deals with issue #32699.

@tobiasKaminsky, @PVince81

@PVince81 PVince81 added 3. to review Waiting for reviews enhancement labels Aug 15, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 15, 2022
@PVince81
Copy link
Member

  • BUG: running occ app:list alone shows an error but should actually show both enabled and disabled.

I think you can remove the error when both are specified.

@PVince81

This comment was marked as resolved.

Sign in to view
@adam-blakey
Copy link
Contributor Author

@PVince81 apologies, I'm an idiot. I've made those corrections and believe this may be working now. Could you check and let me know if this is now okay?

@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@adam-blakey
Copy link
Contributor Author

@PVince81 I somehow didn't get the notifications for the above mentions, so sorry for the delay. Could you take another look at this when you get the chance? Perhaps I'm being really silly but I can't figure out why the code is failing 4 of the above automatic tests. Any help would be appreciated.

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz removed this from the Nextcloud 27 milestone May 23, 2023
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
@skjnldsv skjnldsv requested review from nickvergessen, juliushaertl, come-nc, a team, ArtificialOwl and Fenn-CS and removed request for a team March 15, 2024 14:57
@skjnldsv skjnldsv added the pending documentation This pull request needs an associated documentation update label Mar 15, 2024
come-nc
come-nc reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from overcomplicated if.

core/Command/App/ListApps.php Outdated Show resolved Hide resolved
come-nc
come-nc approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works 👍

@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
@Altahrim
Copy link
Collaborator

@adam-blakey Could you rebase, reword your commit using conventional commit and fix the style please?
For style, you can use composer cs:fix

adam-blakey and others added 2 commits March 18, 2024 15:45
@adam-blakey @come-nc
Update core/Command/App/ListApps.php
aa09af8 
refactor: changed overcomplicated if statement into two shorter lines

Co-authored-by: Côme Chilliet <[email protected]>
Signed-off-by: Adam Blakey <[email protected]>
@adam-blakey
style: Fixed style from composer cs:fix
4744b02 
Signed-off-by: Adam Blakey <[email protected]>
@adam-blakey adam-blakey force-pushed the show-enabled-and-disabled-apps branch from cf8451b to 4744b02 Compare March 18, 2024 15:49
@adam-blakey
Copy link
Contributor Author

@Altahrim Could you check this over again? I'm pretty new to this, so please let me know if there's anything else I need to do.

@nickvergessen
Copy link
Member

Performance testing / performance-8.0 (pull_request) Failing after 9m

is expected for forks

Block unconventional commits / Block unconventional commits (pull_request)

is fine for community, feel free to read https://www.conventionalcommits.org/en/v1.0.0/ and apply it next time :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 19, 2024
@skjnldsv skjnldsv merged commit fcde3b2 into nextcloud:master Mar 19, 2024
164 of 166 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 19, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@ericloyd ericloyd mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: apps management feature: occ pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

occ app:list --disabled
8 participants
@adam-blakey @PVince81 @Altahrim @nickvergessen @skjnldsv @come-nc @joshtrichards @blizzz