oc_token should be nc_token #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
|
@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @tanghus to be potential reviewers. |
|
Any noticable impact? |
Dunno, but I hope @LukasReschke does 😉 |
ChristophWurst
added
3. to review
LukasReschke
approved these changes
Feb 6, 2017
| @@ -98,7 +98,7 @@ function __construct($appName, | |||
| * @return RedirectResponse | |||
| */ | |||
| public function logout() { | |||
| $loginToken = $this->request->getCookie('oc_token'); | |||
| $loginToken = $this->request->getCookie('nc_token'); | |||
There was a problem hiding this comment.
Please prepare backport of this single change also to all older versions where you changed the cookie name.
Nothing too horrible:
The second one should be backported. The first one I'd avoid. @ChristophWurst can you take care of that? THX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this inconsistency when I took a look at #3361.
The cookie is set here:
server/lib/private/User/Session.php
Line 795 in a3f8358
@LukasReschke as discussed 😉