Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert file_metadata.id from int(11) to bigint(20) #34067

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

timm2k
Copy link
Contributor

@timm2k timm2k commented Sep 14, 2022

file_metadata.id runs out of range for very large instances.

file_metadata.id needs to be bigint(20).

Signed-off-by: timm2k <[email protected]>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 14, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 14, 2022
@artonge
Copy link
Contributor

artonge commented Sep 14, 2022

Backport ?

@CarlSchwan
Copy link
Member

/backport to stable24

@nickvergessen
Copy link
Member

/backport to stable24

@nickvergessen
Copy link
Member

Should also change the migration which creates the column, otherwise you do a new install and have a warning waiting for you

@timm2k
Copy link
Contributor Author

timm2k commented Sep 15, 2022

Should also change the migration which creates the column, otherwise you do a new install and have a warning waiting for you

is this done by chaning core/Migrations/Version24000Date20220404230027.php?

@@ -45,7 +45,7 @@
 
 		if (!$schema->hasTable('file_metadata')) {
 			$table = $schema->createTable('file_metadata');
-			$table->addColumn('id', Types::INTEGER, [
+			$table->addColumn('id', Types::BIGINT, [
 				'notnull' => true,
 			]);
 			$table->addColumn('group_name', Types::STRING, [

@nickvergessen
Copy link
Member

Yes

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants