CI exclude ObjectStore tests on normal runs #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @DeepDiver1975 and @schiessle to be potential reviewers |
* Also allow the testsuite selection in autotest.sh
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### | ||
|
|
||
| ErrorDocument 403 /core/templates/403.php | ||
| ErrorDocument 404 /core/templates/404.php |
|
Using groups would be nicer (no need to edit phpunit.xml) but I'm fine with this if groups can't work |
|
@icewind1991 yeah I tend to agree after thinking more about it. Let me take a look tomorrow. |
This was referenced Sep 5, 2021
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can't run them anyway we better exclude them properly
I'm still thinking if we are better of doing this with groups? Or different suites.
Same approach I want to take with testing the different memcache backends. Isolate them in suites. And just run them with the required backend available.
CC: @MorrisJobke