Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupOfUniqueNames as valid group object class #349

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

icewind1991
Copy link
Member

cc @blizzz

@icewind1991 icewind1991 added 3. to review Waiting for reviews feature: ldap labels Jul 8, 2016
@icewind1991 icewind1991 added this to the Nextcloud Next milestone Jul 8, 2016
@icewind1991
Copy link
Member Author

ping @blizzz

@LukasReschke
Copy link
Member

@blizzz Can you comment on that? :)

@MorrisJobke
Copy link
Member

👍 from my side

@blizzz
Copy link
Member

blizzz commented Jul 26, 2016

LGTM

@blizzz blizzz merged commit f88109b into master Jul 26, 2016
@blizzz blizzz deleted the ldab-groupOfUniqueNames branch July 26, 2016 21:32
@blizzz
Copy link
Member

blizzz commented Jul 26, 2016

btw, what is the reason behind this PR?

@icewind1991
Copy link
Member Author

btw, what is the reason behind this PR?

Some setups use groupOfUniquenames to associate groups, without this pr the ldap wizzard does not see it as a valid group type.

Backport to 10? other people are running into the bug in [the wild](btw, what is the reason behind this PR?) (cc @karlitschek )

@karlitschek
Copy link
Member

backport is fine with @blizzz agrees 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants