Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Fix HTML entities not decoded in comment just added #35100

Merged
merged 3 commits into from
Nov 24, 2022
Merged

[stable24] Fix HTML entities not decoded in comment just added #35100

merged 3 commits into from
Nov 24, 2022

Commits on Nov 24, 2022

  1. Extract "decodeHtmlEntities" function to its own file 

    This will make possible to use it from files other than
"GetComments.js".

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    39a4ba2 View commit details
    Browse the repository at this point in the history

  2. Fix HTML entities not decoded in comment just added 

    The XML data received from the comments endpoint has an inconsistent
encoding; some entities are encoded once and others are encoded twice.
When the comment list is loaded the comments are fetched using
GetComments, which handles all that, and therefore shows the messages
and author names as expected.

However, when a new comment is posted the list is not got again; instead
the new comment is loaded from the comment data returned after posting
it. This is done in NewComment, which did not decode the messages nor
the author names, and therefore showed, for example, "&amp;" instead of
"&".

To solve that now the same decoding logic used in GetComments is applied
too in NewComment.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d3807ea View commit details
    Browse the repository at this point in the history

  3. Compile assets 

    Signed-off-by: nextcloud-command <[email protected]>
    @nextcloud-command
    nextcloud-command committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    2bdd9ac View commit details
    Browse the repository at this point in the history