Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kerberos sso test setup to use new user_saml config system #36314

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

icewind1991
Copy link
Member

An update to user_saml broke the way the automated config was done previously

Fixes #36163

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 23, 2023
@icewind1991 icewind1991 added this to the Nextcloud 26 milestone Jan 23, 2023
@icewind1991 icewind1991 requested review from come-nc, a team, ArtificialOwl and blizzz and removed request for a team January 23, 2023 17:24
@come-nc
Copy link
Contributor

come-nc commented Jan 24, 2023

CI failures are unrelated

@come-nc come-nc merged commit 17ed023 into master Feb 7, 2023
@come-nc come-nc deleted the sso-kerberos-fix branch February 7, 2023 10:16
@blizzz blizzz mentioned this pull request Feb 9, 2023
@artonge
Copy link
Contributor

artonge commented Apr 25, 2023

Makes sense to backport?

@artonge
Copy link
Contributor

artonge commented Apr 25, 2023

/backport to stable25

@artonge
Copy link
Contributor

artonge commented Apr 25, 2023

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin/stable24

# Create the new backport branch
git checkout -b fix/foo-stable24

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SMB Kerberos SSO tests failing
5 participants