-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sharing): Remove casting to int from INF #36524
fix(sharing): Remove casting to int from INF #36524
Conversation
Psalm error is fixed by https://github.com/nextcloud/server/pull/36120/files#diff-728c72d2e598172d145e57ed10fdbf1fc107aa73fa75af827418aa16895c3a38R355 @come-nc can I copy that one method to this PR and you rebase afterwards? |
I’m pretty sure you will get psalm errors somewhere else, no? Do if you must, but I’d rather merge 32bit first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it 💙
Just add the false reported problem to psalms baseline for now? |
No one is going to remove it. But will clarify with Come once he arrives at the office |
Regression from #35736 INF is a the float INF, casting it to integer will make it 0 Signed-off-by: Joas Schilling <[email protected]>
4eb77ff
to
80071bd
Compare
Rebased for green CI |
Failing acceptance-header menu is flickering again:
|
Regression from #35736
INF is a the float value
INF
, casting it to integer will make it 0https://3v4l.org/IH4Xc
Checklist