dont delegate Mount\Manager::getByNumericId to getByStorageId #36566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
come-nc
and removed request for
a team
come-nc
approved these changes
Feb 7, 2023
icewind1991
force-pushed
the
mount-find-by-numeric-id
branch
2 times, most recently
from
0cb467f
to
cd04615
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
mount-find-by-numeric-id
branch
from
cd04615
to
7fd96c2
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
mount-find-by-numeric-id
branch
from
7fd96c2
to
9f3dbb6
Compare
juliushaertl
approved these changes
Feb 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be faster than getting the string storage id
Also includes a bonus cleanup of
getByStorageId