Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): Fix public_key_credential_id length #36769

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions core/Migrations/Version25000Date20230217195657.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?php

declare(strict_types=1);

/**
* @copyright 2023 Zev Lee <[email protected]>
*
* @author Zev Lee <[email protected]>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

namespace OC\Core\Migrations;

use Closure;
use OCP\IDBConnection;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;

class Version25000Date20230217195657 extends SimpleMigrationStep {
public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {

Check failure on line 35 in core/Migrations/Version25000Date20230217195657.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedClass

core/Migrations/Version25000Date20230217195657.php:35:89: UndefinedClass: Class, interface or enum named OC\Core\Migrations\ISchemaWrapper does not exist (see https://psalm.dev/019)

Check failure

Code scanning / Psalm

UndefinedClass Error

Class, interface or enum named OC\Core\Migrations\ISchemaWrapper does not exist
/** @var ISchemaWrapper $schema */
$schema = $schemaClosure();

Check failure on line 37 in core/Migrations/Version25000Date20230217195657.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedDocblockClass

core/Migrations/Version25000Date20230217195657.php:37:3: UndefinedDocblockClass: Docblock-defined class, interface or enum named OC\Core\Migrations\ISchemaWrapper does not exist (see https://psalm.dev/200)

Check failure

Code scanning / Psalm

UndefinedDocblockClass Error

Docblock-defined class, interface or enum named OC\Core\Migrations\ISchemaWrapper does not exist

$registrationsTable = $schema->getTable('webauthn');

Check failure on line 39 in core/Migrations/Version25000Date20230217195657.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedDocblockClass

core/Migrations/Version25000Date20230217195657.php:39:25: UndefinedDocblockClass: Docblock-defined class, interface or enum named OC\Core\Migrations\ISchemaWrapper does not exist (see https://psalm.dev/200)

Check failure

Code scanning / Psalm

UndefinedDocblockClass Error

Docblock-defined class, interface or enum named OC\Core\Migrations\ISchemaWrapper does not exist
/**
* Fixes https://github.com/nextcloud/server/issues/34476
*/
$registrationsTable
->getColumn('public_key_credential_id')
->setLength(512);

return $schema;

Check failure on line 47 in core/Migrations/Version25000Date20230217195657.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

InvalidReturnStatement

core/Migrations/Version25000Date20230217195657.php:47:10: InvalidReturnStatement: The inferred type 'OC\Core\Migrations\ISchemaWrapper' does not match the declared return type 'OCP\DB\ISchemaWrapper&OC\Core\Migrations\ISchemaWrapper|null' for OC\Core\Migrations\Version25000Date20230217195657::changeSchema (see https://psalm.dev/128)

Check failure

Code scanning / Psalm

InvalidReturnStatement Error

The inferred type 'OC\Core\Migrations\ISchemaWrapper' does not match the declared return type 'OCP\DB\ISchemaWrapper&OC\Core\Migrations\ISchemaWrapper|null' for OC\Core\Migrations\Version25000Date20230217195657::changeSchema
}
}
Loading