fix: Remove duplicate memory session creation on cron jobs

[juliushaertl]

Summary

There might be scenarios (especially on previous versions where session writes do not reopen) where application code lie the encryption KeyManager still holds the previously initialized Memory session which they obtained through DI. There should be no need to close the existing one and create a new one and crypto wrappers should also be unneeded as we are storing in memory only anyways.

There is already a memory session by default which is available if no session is set manually through OC::initSession or the calls removed in ths PR.

server/lib/private/Server.php

Line 561 in a2afc7b

$session = new \OC\Session\Memory('');

TODO

• Waiting for CI

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Fenn-CS]

Makes sense!

[come-nc]

I do not grasp what this is about…
git says @nickvergessen touched these lines, do you know more?

[nickvergessen]

PR was owncloud/core#18482
🤔

[icewind1991]

Would it make more sense to move the explicit memory session creation to before the app loading?

[juliushaertl]

Closing as I cannot reproduce the underlying issue anymore.