-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate federation application to LoggerInterface #39018
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
*/ | ||
public function execute(IJobList $jobList, ILogger $logger = null) { | ||
public function start(IJobList $jobList): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a public method, just double checking to ensure you have checked for references in other parts of the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the parent class OCP\BackgroundJob\Job
is migrating from execute
to start
since 25, I think we should even deprecate execute
since it’s always a problem for migrating away from ILogger
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue for that? If not I could create one and deprecate it rn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I just saw that execute
is already deprecated in IJob
interface.
Maybe it would still be a good idea to mark it as deprecated in Job
class as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
See #32127
Migrate federation application from ILogger to LoggerInterface
Checklist