refactor lib/private/Notification #39174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
reviewed
Jul 17, 2023
artonge
approved these changes
Aug 17, 2023
Merged
shdehnavi
force-pushed
the
refactor_lib_private_notification
branch
from
343322f
to
576f5f6
Compare
|
@blizzz All conflicts have been resolved, Ready to merge |
come-nc
approved these changes
Dec 14, 2023
artonge
force-pushed
the
refactor_lib_private_notification
branch
from
576f5f6
to
8480b9d
Compare
|
Rebased to see if Cypress gets green. If not, can you try to check what's happening locally @shdehnavi? |
shdehnavi
force-pushed
the
refactor_lib_private_notification
branch
from
8480b9d
to
43f3219
Compare
I often encounter errors in Cypress jobs with most of my pull requests. I have rebased the code but nothing changed, still the same as earlier. |
The docker image was outdated, I released a new version, Cypress tests are now green :) |
Signed-off-by: Hamid Dehnavi <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Louis Chemineau <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
come-nc
force-pushed
the
refactor_lib_private_notification
branch
from
43f3219
to
82a503a
Compare
|
Looks like drone is not triggered. And the performance step looks not related. Merging |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in
/lib/private/Notificationnamespace.The improvements:
Checklist