Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP8's match expression instead of switch #39209

Conversation

shdehnavi
Copy link
Contributor

Summary

Using PHP8's match expression instead of switch in the /tests/lib namespace classes.

Checklist

@shdehnavi shdehnavi requested a review from come-nc July 8, 2023 20:43
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@come-nc
Copy link
Contributor

come-nc commented Jul 17, 2023

I’m not sure what good that brings apart from complicating backport on tests.
For core code I can see the impulse for wanting to have the cleaner code as possible, but for tests it is less true, and here it is not clear what is the benefit.
Match is tiny bit shorter but it’s also less known by developers.

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@come-nc
Copy link
Contributor

come-nc commented Feb 26, 2024

Closing as per comment

@come-nc come-nc closed this Feb 26, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants