Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dashboard app #39244

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the dashboard app.

The improvements:

  • Using PHP8's constructor property promotion
  • Adding types to properties

Checklist

Signed-off-by: Hamid Dehnavi <[email protected]>
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
shdehnavi and others added 2 commits July 14, 2023 17:46
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2024
@skjnldsv skjnldsv merged commit 6cac8d0 into nextcloud:master Feb 28, 2024
149 of 157 checks passed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants